[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/4] Introduce yank feature
From: |
Lukas Straub |
Subject: |
Re: [PATCH v4 1/4] Introduce yank feature |
Date: |
Fri, 19 Jun 2020 18:29:24 +0200 |
On Wed, 17 Jun 2020 16:12:40 +0100
Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Mon, May 25, 2020 at 05:44:23PM +0200, Lukas Straub wrote:
> > +static struct YankInstance *yank_find_instance(char *name)
>
> There are const char * -> char * casts in later patches. Please use
> const char * where possible. Callers shouldn't need to cast away const.
nbd and chardev generate the instance name dynamically so it needs to be char
*, but in migration it's hardcoded.
Thanks,
Lukas Straub
pgpdrN2Mu5lAZ.pgp
Description: OpenPGP digital signature