Re: [PATCH v2 0/3] Add Scripts for Finding Top 25 Executed Functions

[Aleksandar Markovic]

петак, 19. јун 2020., Ahmed Karaman <ahmedkhaledkaraman@gmail.com> је написао/ла:
> Greetings,
>
> This series implements the improvements and changes requested to be
> added to the two scripts.
>
> Thanks to Mr. Aleksandar Markovic, Mr. Alex Bennée, and Mr. Eric Blake
> for their valuable feedback.
>
> First version of the series:
> https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg04868.html

The cover letters for v2, v3,... should repeat the core text of the original cover letter. You can keep this link above, but you must repeat the almost all text of v1 cover letter in v2, v3,... too. Any version of any series should be a stand-alone unit, and the reader should not be forced to look at the previous versions to find out what the series is really about, which is the case now for this v2 of your series.

Thanks,

Aleksandar

> Best regards,
> Ahmed Karaman
>
> v1->v2:
> - Add an empty line at the end of the MAINTAINERS file.
> - Move MAINTAINERS patch to be the last in the series.
> - Allow custom number of top functions to be specified.
> - Check for vallgrind and perf before executing the scripts.
> - Ensure sufficient permissions when running the topN_perf script.
> - Use subprocess instead of os.system
> - Use os.unlink() for deleting intermediate files.
> - Spread out the data extraction steps.
> - Enable execution permission for the scripts.
> - Add script example output in the commit message.
>
> Ahmed Karaman (3):
>   scripts/performance: Add topN_perf.py script
>   scripts/performance: Add topN_callgrind.py script
>   MAINTAINERS: Add 'Performance Tools and Tests' subsection
>
>  MAINTAINERS                           |   7 ++
>  scripts/performance/topN_callgrind.py | 131 ++++++++++++++++++++++++++
>  scripts/performance/topN_perf.py      | 115 ++++++++++++++++++++++
>  3 files changed, 253 insertions(+)
>  create mode 100755 scripts/performance/topN_callgrind.py
>  create mode 100755 scripts/performance/topN_perf.py
>
> -- 
> 2.17.1