qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH rc1 12/15] hw/rx: Register R5F562N7 and R5F562N8 MCUs


From: Richard Henderson
Subject: Re: [PATCH rc1 12/15] hw/rx: Register R5F562N7 and R5F562N8 MCUs
Date: Sat, 20 Jun 2020 10:31:19 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/17/20 12:15 PM, Philippe Mathieu-Daudé wrote:
> +    /* XTAL range: 8-14 MHz */
> +    if (s->xtal_freq_hz < 8e6 || s->xtal_freq_hz > 14e6) {
> +        error_setg(errp, "\"xtal-frequency-hz\" property in incorrect 
> range.");
> +        return;
> +    }
> +    /* Use a 4x fixed multiplier */
> +    s->pclk_freq_hz = 4 * s->xtal_freq_hz;
> +    /* PCLK range: 8-50 MHz */
> +    assert(s->pclk_freq_hz <= 50e6);

It's just startup, so it's not vital, but forcing floating-point comparisons
just because the notation is shorter isn't ideal.

Perhaps just a local "const uint32_t MHz = 10000000;", and some multiplies.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]