[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interf
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v9 1/5] hw/nvram/fw_cfg: Add the FW_CFG_DATA_GENERATOR interface |
|
Date: |
Sat, 20 Jun 2020 10:52:43 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/16/20 8:31 AM, Daniel P. Berrangé wrote:
> fw_cfg_add_file(s, filename, g_byte_array_steal(data, NULL),
> (guint)g_byte_array_get_size(data));
FWIW, you can't both read the size and steal the data in the argument list like
this -- the evaluation order is unspecified.
r~