[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/7] hw/misc/mps2-scc: Use the LED device
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v3 6/7] hw/misc/mps2-scc: Use the LED device |
|
Date: |
Sun, 21 Jun 2020 14:05:19 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 |
On 6/20/20 4:07 PM, Philippe Mathieu-Daudé wrote:
> @@ -25,6 +25,7 @@ typedef struct {
>
> /*< public >*/
> MemoryRegion iomem;
> + DeviceState *led[8];
LEDState?
> + for (size_t i = 0; i < ARRAY_SIZE(s->led); i++) {
> + led_set_state(LED(s->led[i]), !!extract32(value, i, 1));
> + }
No need for !!.
r~
- Re: [PATCH v3 3/7] hw/misc/led: Emit a trace event when LED intensity has changed, (continued)
[PATCH v3 4/7] hw/arm/aspeed: Add the 3 front LEDs drived by the PCA9552 #1, Philippe Mathieu-Daudé, 2020/06/20
[PATCH v3 5/7] hw/misc/mps2-fpgaio: Use the LED device, Philippe Mathieu-Daudé, 2020/06/20
[PATCH v3 6/7] hw/misc/mps2-scc: Use the LED device, Philippe Mathieu-Daudé, 2020/06/20
[PATCH v3 7/7] hw/arm/tosa: Replace fprintf() calls by LED devices, Philippe Mathieu-Daudé, 2020/06/20
Re: [PATCH v3 0/7] hw/misc: Add LED device, no-reply, 2020/06/20