[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 8/9] pc-bios: s390x: Use ebcdic2ascii table
From: |
Janosch Frank |
Subject: |
[PATCH v4 8/9] pc-bios: s390x: Use ebcdic2ascii table |
Date: |
Mon, 22 Jun 2020 03:42:34 -0400 |
Why should we do conversion of a ebcdic value if we have a handy table
where we could look up the ascii value instead?
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
---
pc-bios/s390-ccw/bootmap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c
index d13b7cbd15..97205674e5 100644
--- a/pc-bios/s390-ccw/bootmap.c
+++ b/pc-bios/s390-ccw/bootmap.c
@@ -328,9 +328,7 @@ static void print_eckd_ldl_msg(ECKD_IPL_mode_t mode)
msg[0] = '2';
break;
default:
- msg[0] = vlbl->LDL_version;
- msg[0] &= 0x0f; /* convert EBCDIC */
- msg[0] |= 0x30; /* to ASCII (digit) */
+ msg[0] = ebc2asc[vlbl->LDL_version];
msg[1] = '?';
break;
}
--
2.25.1
- [PATCH v4 0/9] pc-bios: s390x: Cleanup part 1, Janosch Frank, 2020/06/22
- [PATCH v4 1/9] pc-bios: s390x: cio.c cleanup and compile fix, Janosch Frank, 2020/06/22
- [PATCH v4 4/9] pc-bios: s390x: Get rid of magic offsets into the lowcore, Janosch Frank, 2020/06/22
- [PATCH v4 3/9] pc-bios: s390x: Move sleep and yield to helper.h, Janosch Frank, 2020/06/22
- [PATCH v4 2/9] pc-bios: s390x: Consolidate timing functions into time.h, Janosch Frank, 2020/06/22
- [PATCH v4 6/9] pc-bios: s390x: Use PSW masks where possible and introduce PSW_MASK_SHORT_ADDR, Janosch Frank, 2020/06/22
- [PATCH v4 8/9] pc-bios: s390x: Use ebcdic2ascii table,
Janosch Frank <=
- [PATCH v4 9/9] pc-bios: s390x: Make u32 ptr check explicit, Janosch Frank, 2020/06/22
- [PATCH v4 5/9] pc-bios: s390x: Rename and use PSW_MASK_ZMODE constant, Janosch Frank, 2020/06/22
- [PATCH v4 7/9] pc-bios: s390x: Move panic() into header and add infinite loop, Janosch Frank, 2020/06/22
- Re: [PATCH v4 0/9] pc-bios: s390x: Cleanup part 1, no-reply, 2020/06/22