[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 13/18] tests/docker: check for an parameters not empty str
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v1 13/18] tests/docker: check for an parameters not empty string |
|
Date: |
Mon, 22 Jun 2020 16:46:41 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/22/20 4:31 PM, Alex Bennée wrote:
> Reported-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Suggested-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> tests/docker/common.rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 02cd67a8c5e..b27ce17e333 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -47,7 +47,7 @@ build_qemu()
> check_qemu()
> {
> # default to make check unless the caller specifies
> - if test -z "$@"; then
> + if [ $# == 0 ]; then
> INVOCATION="check"
> else
> INVOCATION="$@"
>
- [PATCH v1 04/18] tests/vm: Added configuration file support, (continued)
- [PATCH v1 13/18] tests/docker: check for an parameters not empty string, Alex Bennée, 2020/06/22
- [PATCH v1 14/18] .gitignore: un-ignore .gitlab-ci.d, Alex Bennée, 2020/06/22
- [PATCH v1 11/18] tests/vm: switch from optsparse to argparse, Alex Bennée, 2020/06/22
- [PATCH v1 09/18] python/qemu: Add ConsoleSocket for optional use in QEMUMachine, Alex Bennée, 2020/06/22
- [PATCH v1 16/18] .gitlab: split fedora-misc-disabled, Alex Bennée, 2020/06/22
- [PATCH v1 17/18] .gitlab: tag remaining jobs as builds, Alex Bennée, 2020/06/22
- [PATCH v1 15/18] .gitlab: add acceptance testing to system builds, Alex Bennée, 2020/06/22