Re: [PULL v2 39/58] Transmit vhost-user memory regions individually

[Raphael Norwitz]

On Fri, Jun 19, 2020 at 6:03 AM Peter Maydell <peter.maydell@linaro.org> wrote:
>
>
> As noted in my other email, I think the best fix for this is to
> have vhost_user_fill_msg_region() take an extra mmap_offset
> argument to fill in the mmap_offset itself. In this callsite in
> send_add_regions() we would pass in 'offset' and delete the manual
> assignment to .mmap_offset. I'm not sure about the call in
> send_remove_regions() but I guess if the intention is that the
> payload field is not relevant then passing in '0' would be right.
>

Yes - for the places where the mmap_offset isn't needed 0 is right.

Sounds good to me - I just sent in a patch.

> thanks
> -- PMM
>