Re: [PATCH] qom: Allow object_property_add_child() to fail

[Auger Eric]

Hi Paolo,

On 6/23/20 6:22 PM, Paolo Bonzini wrote:
> On 23/06/20 17:54, Eric Auger wrote:
>> This patch introduces two new functions, object_property_add_err() and
>> object_property_add_child_err() whose prototype features an error handle.
>> object_property_add_child_err() now gets called from user_creatable_add_type.
>> This solution was chosen instead of changing the prototype of existing
>> functions because the number of existing callers is huge.
> 
> The idea is good, but I would rather name the functions
> object_property_try_add{,_child} to follow e.g. g_try_malloc.
> 
> In fact, the existing function object_property_try_add can simply be
> made non-static.

Sure I will respin accordingly

Thanks

Eric
> 
> Paolo
>