Re: [PATCH v9 5/5] new qTest case to test the vhost-user-blk-server

[Stefan Hajnoczi]

On Wed, Jun 24, 2020 at 12:35:10PM +0800, Coiby Xu wrote:
> On Thu, Jun 18, 2020 at 04:17:51PM +0100, Stefan Hajnoczi wrote:
> > On Mon, Jun 15, 2020 at 02:39:07AM +0800, Coiby Xu wrote:
> > > This test case has the same tests as tests/virtio-blk-test.c except for
> > > tests have block_resize. Since vhost-user server can only server one
> > > client one time, two instances of qemu-storage-daemon are launched
> > > for the hotplug test.
> > > 
> > > In order to not block scripts/tap-driver.pl, vhost-user-blk-server will
> > > send "quit" command to qemu-storage-daemon's QMP monitor. So a function
> > > is added to libqtest.c to establish socket connection with socket
> > > server.
> > > 
> > > Signed-off-by: Coiby Xu <coiby.xu@gmail.com>
> > > ---
> > >  tests/Makefile.include              |   3 +-
> > >  tests/qtest/Makefile.include        |   2 +
> > >  tests/qtest/libqos/vhost-user-blk.c | 130 +++++
> > >  tests/qtest/libqos/vhost-user-blk.h |  48 ++
> > >  tests/qtest/libqtest.c              |  35 +-
> > >  tests/qtest/libqtest.h              |  17 +
> > >  tests/qtest/vhost-user-blk-test.c   | 739 ++++++++++++++++++++++++++++
> > >  7 files changed, 971 insertions(+), 3 deletions(-)
> > >  create mode 100644 tests/qtest/libqos/vhost-user-blk.c
> > >  create mode 100644 tests/qtest/libqos/vhost-user-blk.h
> > >  create mode 100644 tests/qtest/vhost-user-blk-test.c
> > 
> > This test case fails for me:
> > 
> > qemu-system-x86_64: Failed to read from slave.
> > qemu-system-x86_64: Failed to set msg fds.
> > qemu-system-x86_64: vhost VQ 0 ring restore failed: -1: Success (0)
> > qemu-system-x86_64: Failed to read from slave.
> > qemu-system-x86_64: Failed to read from slave.
> > qemu-system-x86_64: Failed to read from slave.
> > qemu-system-x86_64: Failed to set msg fds.
> > qemu-system-x86_64: vhost VQ 0 ring restore failed: -1: Success (0)
> > qemu-system-x86_64: Failed to read msg header. Read -1 instead of 12. 
> > Original request 11.
> > qemu-system-x86_64: vhost VQ 0 ring restore failed: -1: Input/output error 
> > (5)
> > 
> > Does "make -j4 check" pass for you?
> 
> Actually it's a success since it won't fail CI. The reason for the
> occurrence of these dubious messages is after finishing the tests,
> vhost-user-blk-server is stopped before qemu-system-x86_64 is destroyed.
> I'll see if I can find a way to kill qemu-system-x86_64 first.

Maybe I didn't even notice whether it was passing or failing and just
got scared by these messages! :)

Thanks for explaining. It would be good to terminate cleanly to avoid
confusing users.

Stefan

signature.asc
Description: PGP signature