[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 37/46] qom: Make functions taking Error ** return bool, not v
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 37/46] qom: Make functions taking Error ** return bool, not void |
Date: |
Thu, 25 Jun 2020 17:14:28 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Eric Blake <eblake@redhat.com> writes:
> On 6/24/20 11:43 AM, Markus Armbruster wrote:
>> See recent commit "error: Document Error API usage rules" for
>> rationale.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>
>> @@ -524,25 +527,29 @@ void object_initialize(void *data, size_t size, const
>> char *typename)
>> object_initialize_with_type(data, size, type);
>> }
>> -void object_initialize_child_with_props(Object *parentobj,
>> +bool object_initialize_child_with_props(Object *parentobj,
>> const char *propname,
>> void *childobj, size_t size, const char *type,
>> Error **errp, ...)
>
> Is it worth tweaking indentation while here?
Can do.
> Reviewed-by: Eric Blake <eblake@redhat.com>
Thanks!
- [PATCH 25/46] qapi: Smooth visitor error checking in generated code, (continued)
- [PATCH 25/46] qapi: Smooth visitor error checking in generated code, Markus Armbruster, 2020/06/24
- [PATCH 23/46] qapi: Smooth error checking with Coccinelle, Markus Armbruster, 2020/06/24
- [PATCH 30/46] s390x/pci: Fix harmless mistake in zpci's property fid's setter, Markus Armbruster, 2020/06/24
- [PATCH 37/46] qom: Make functions taking Error ** return bool, not void, Markus Armbruster, 2020/06/24
- [PATCH 26/46] qapi: Smooth another visitor error checking pattern, Markus Armbruster, 2020/06/24
- [PATCH 24/46] qapi: Smooth error checking manually, Markus Armbruster, 2020/06/24
- [PATCH 17/46] qemu-option: Smooth error checking with Coccinelle, Markus Armbruster, 2020/06/24
- [PATCH 15/46] qemu-option: Tidy up opt_set() not to free arguments on failure, Markus Armbruster, 2020/06/24