[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/11] mac_oldworld: Rename ppc_heathrow_reset to ppc_heat
From: |
Mark Cave-Ayland |
Subject: |
Re: [PATCH v5 06/11] mac_oldworld: Rename ppc_heathrow_reset to ppc_heathrow_cpu_reset |
Date: |
Fri, 26 Jun 2020 13:55:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 16/06/2020 14:47, BALATON Zoltan wrote:
> This function resets a CPU not the whole machine so reflect that in
> its name.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/ppc/mac_oldworld.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
> index 4200008851..f97f241e0c 100644
> --- a/hw/ppc/mac_oldworld.c
> +++ b/hw/ppc/mac_oldworld.c
> @@ -73,7 +73,7 @@ static uint64_t translate_kernel_address(void *opaque,
> uint64_t addr)
> return (addr & 0x0fffffff) + KERNEL_LOAD_ADDR;
> }
>
> -static void ppc_heathrow_reset(void *opaque)
> +static void ppc_heathrow_cpu_reset(void *opaque)
> {
> PowerPCCPU *cpu = opaque;
>
> @@ -112,7 +112,7 @@ static void ppc_heathrow_init(MachineState *machine)
>
> /* Set time-base frequency to 16.6 Mhz */
> cpu_ppc_tb_init(env, TBFREQ);
> - qemu_register_reset(ppc_heathrow_reset, cpu);
> + qemu_register_reset(ppc_heathrow_cpu_reset, cpu);
> }
>
> /* allocate RAM */
As per my previous comment on your earlier version, I don't agree with this -
the
reset is being registered at board level, it just so happens that as it's only
touching the CPU due to the opaque being passed in.
I'd be inclined to pass in a suitable HeathrowMachineState object containing a
reference to the CPU instead.
ATB,
Mark.
- Re: [PATCH v5 01/11] mac_oldworld: Allow loading binary ROM image, (continued)
- [PATCH v5 02/11] mac_newworld: Allow loading binary ROM image, BALATON Zoltan, 2020/06/16
- [PATCH v5 04/11] mac_oldworld: Drop some variables, BALATON Zoltan, 2020/06/16
- [PATCH v5 07/11] mac_oldworld: Map macio to expected address at reset, BALATON Zoltan, 2020/06/16
- [PATCH v5 06/11] mac_oldworld: Rename ppc_heathrow_reset to ppc_heathrow_cpu_reset, BALATON Zoltan, 2020/06/16
- Re: [PATCH v5 06/11] mac_oldworld: Rename ppc_heathrow_reset to ppc_heathrow_cpu_reset,
Mark Cave-Ayland <=
- [PATCH v5 03/11] mac_oldworld: Drop a variable, use get_system_memory() directly, BALATON Zoltan, 2020/06/16
- [PATCH v5 08/11] mac_oldworld: Add machine ID register, BALATON Zoltan, 2020/06/16
- [PATCH v5 05/11] grackle: Set revision in PCI config to match hardware, BALATON Zoltan, 2020/06/16
- [PATCH v5 10/11] WIP macio/cuda: Attempt to add i2c support, BALATON Zoltan, 2020/06/16
- [PATCH v5 09/11] macio: Add dummy screamer register area, BALATON Zoltan, 2020/06/16