[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 2/3] hw/i2c/smbus_eeprom: Add description based on child
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH 2/3] hw/i2c/smbus_eeprom: Add description based on child name |
Date: |
Fri, 26 Jun 2020 16:26:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/26/20 1:00 PM, BALATON Zoltan wrote:
> On Fri, 26 Jun 2020, Philippe Mathieu-Daudé wrote:
>> Suggested-by: Markus Armbruster <armbru@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> hw/i2c/smbus_eeprom.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/hw/i2c/smbus_eeprom.c b/hw/i2c/smbus_eeprom.c
>> index 879fd7c416..22ba7b20d4 100644
>> --- a/hw/i2c/smbus_eeprom.c
>> +++ b/hw/i2c/smbus_eeprom.c
>> @@ -47,6 +47,7 @@ typedef struct SMBusEEPROMDevice {
>> uint8_t *init_data;
>> uint8_t offset;
>> bool accessed;
>> + char *description;
>> } SMBusEEPROMDevice;
>>
>> static uint8_t eeprom_receive_byte(SMBusDevice *dev)
>> @@ -134,7 +135,9 @@ static void smbus_eeprom_realize(DeviceState *dev,
>> Error **errp)
>> smbus_eeprom_reset(dev);
>> if (eeprom->init_data == NULL) {
>> error_setg(errp, "init_data cannot be NULL");
>> + return;
>> }
>> + eeprom->description =
>> object_get_canonical_path_component(OBJECT(dev));
>> }
>>
>> static void smbus_eeprom_class_initfn(ObjectClass *klass, void *data)
>
> What is this for? Shouldn't this description field be in some parent
> object and whatever wants to print it could use the
> object_get_canonical_path_component() as default value if it's not set
> instead of adding more boiler plate to every object?
You are right, if we want to use this field generically, it should be
a static Object field. I'll defer that question to Eduardo/Markus.
>
> Regards,
> BALATON Zoltan
- [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, (continued)
- [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, Philippe Mathieu-Daudé, 2020/06/26
- Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, BALATON Zoltan, 2020/06/26
- Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, BALATON Zoltan, 2020/06/26
- Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, Philippe Mathieu-Daudé, 2020/06/26
- Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, BALATON Zoltan, 2020/06/26
- Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, Philippe Mathieu-Daudé, 2020/06/26
- Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, BALATON Zoltan, 2020/06/26
- Re: [RFC PATCH 1/3] hw/i2c/smbus_eeprom: Set QOM parent, Philippe Mathieu-Daudé, 2020/06/26
[RFC PATCH 2/3] hw/i2c/smbus_eeprom: Add description based on child name, Philippe Mathieu-Daudé, 2020/06/26
[RFC PATCH 3/3] hw/i2c/smbus_eeprom: Trace reset() event, Philippe Mathieu-Daudé, 2020/06/26
Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description, no-reply, 2020/06/26
Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description, no-reply, 2020/06/26
Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description, Aleksandar Markovic, 2020/06/26
Re: [RFC PATCH 0/3] Use object_get_canonical_path_component to get child description, Markus Armbruster, 2020/06/27