[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 00/84] QOM patches for 2020-06-15
From: |
Peter Maydell |
Subject: |
Re: [PULL 00/84] QOM patches for 2020-06-15 |
Date: |
Fri, 26 Jun 2020 19:28:39 +0100 |
On Mon, 15 Jun 2020 at 21:43, Markus Armbruster <armbru@redhat.com> wrote:
>
> The following changes since commit 7d3660e79830a069f1848bb4fa1cdf8f666424fb:
>
> Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
> staging (2020-06-12 23:06:22 +0100)
>
> are available in the Git repository at:
>
> git://repo.or.cz/qemu/armbru.git tags/pull-qom-2020-06-15
>
> for you to fetch changes up to b77b5b3dc7a4730d804090d359c57d33573cf85a:
>
> MAINTAINERS: Make section QOM cover hw/core/*bus.c as well (2020-06-15
> 22:06:04 +0200)
>
> ----------------------------------------------------------------
> QOM patches for 2020-06-15
>
> * Make "info qom-tree" show children sorted
> * Fixes around device realization
> * Rework how we plug into devices into their parent bus
Hi. I've just noticed that this commit added new global-scope
functions to header files without documentation comments, eg
bool qdev_realize_and_unref(DeviceState *dev, BusState *bus, Error **errp);
Please could you provide some follow-up patches that document them?
I don't think we have any hope of getting people to follow whatever
the correct new way to create/configure/realize devices is if we
don't document it :-( [Concrete example: I now have no idea
how this is supposed to work after this patchset.]
thanks
-- PMM
- [PULL 59/84] auxbus: Convert a use of qdev_set_parent_bus(), (continued)
- [PULL 59/84] auxbus: Convert a use of qdev_set_parent_bus(), Markus Armbruster, 2020/06/15
- [PULL 75/84] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3, Markus Armbruster, 2020/06/15
- [PULL 62/84] qom: Less verbose object_initialize_child(), Markus Armbruster, 2020/06/15
- [PULL 71/84] sysbus: Convert to sysbus_realize() etc. with Coccinelle, Markus Armbruster, 2020/06/15
- [PULL 64/84] macio: Eliminate macio_init_child_obj(), Markus Armbruster, 2020/06/15
- [PULL 73/84] sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1, Markus Armbruster, 2020/06/15
- [PULL 77/84] sysbus: sysbus_init_child_obj() is now unused, drop, Markus Armbruster, 2020/06/15
- Re: [PULL 00/84] QOM patches for 2020-06-15, Peter Maydell, 2020/06/16
- Re: [PULL 00/84] QOM patches for 2020-06-15,
Peter Maydell <=