Re: Re: [PATCH v2] chardev/tcp: fix error message double free error

[lichun]

>Hi
>
>On Thu, Jun 25, 2020 at 10:47 AM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> lichun <lichun@ruijie.com.cn> writes:
>>
>> > Signed-off-by: lichun <lichun@ruijie.com.cn>
>> > ---
>> >  chardev/char-socket.c | 3 ++-
>> >  1 file changed, 2 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/chardev/char-socket.c b/chardev/char-socket.c
>> > index afebeec5c3..569d54c144 100644
>> > --- a/chardev/char-socket.c
>> > +++ b/chardev/char-socket.c
>> > @@ -142,6 +142,8 @@ static void check_report_connect_error(Chardev *chr,
>> >                            "Unable to connect character device %s: ",
>> >                            chr->label);
>> >          s->connect_err_reported = true;
>> > +    } else {
>> > +        error_free(err);
>> >      }
>> >      qemu_chr_socket_restart_timer(chr);
>> >  }
>> > @@ -1086,7 +1088,6 @@ static void qemu_chr_socket_connected(QIOTask *task, 
>> > void *opaque)
>> >      if (qio_task_propagate_error(task, &err)) {
>> >          tcp_chr_change_state(s, TCP_CHARDEV_STATE_DISCONNECTED);
>> >          check_report_connect_error(chr, err);
>> > -        error_free(err);
>> >          goto cleanup;
>> >      }
>>
>> Since my "Error handling fixes & cleanups" series fixes similar errors.
>> I'm happy to merge this patch along with it.  Up to Marc-André.
>
>That would be great, thanks! 
Thank you!
>