[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/9] hw/pci-host: add pci-intack write method
From: |
Li Qiang |
Subject: |
Re: [PATCH v2 1/9] hw/pci-host: add pci-intack write method |
Date: |
Mon, 29 Jun 2020 17:20:25 +0800 |
P J P <ppandit@redhat.com> 于2020年6月25日周四 上午2:59写道:
>
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Add pci-intack mmio write method to avoid NULL pointer dereference
> issue.
>
> Reported-by: Lei Sun <slei.casper@gmail.com>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> hw/pci-host/prep.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c
> index 367e408b91..3c8ff6af03 100644
> --- a/hw/pci-host/prep.c
> +++ b/hw/pci-host/prep.c
> @@ -26,6 +26,7 @@
> #include "qemu/osdep.h"
> #include "qemu-common.h"
> #include "qemu/units.h"
> +#include "qemu/log.h"
> #include "qapi/error.h"
> #include "hw/pci/pci.h"
> #include "hw/pci/pci_bus.h"
> @@ -119,8 +120,15 @@ static uint64_t raven_intack_read(void *opaque, hwaddr
> addr,
> return pic_read_irq(isa_pic);
> }
>
> +static void raven_intack_write(void *opaque, hwaddr addr,
> + uint64_t data, unsigned size)
> +{
> + qemu_log_mask(LOG_UNIMP, "%s not implemented\n", __func__);
> +}
> +
> static const MemoryRegionOps raven_intack_ops = {
> .read = raven_intack_read,
> + .write = raven_intack_write,
> .valid = {
> .max_access_size = 1,
> },
> --
> 2.26.2
>
- [PATCH v2 0/9] memory: assert and define MemoryRegionOps callbacks, P J P, 2020/06/24
- [PATCH v2 1/9] hw/pci-host: add pci-intack write method, P J P, 2020/06/24
- Re: [PATCH v2 1/9] hw/pci-host: add pci-intack write method,
Li Qiang <=
- [PATCH v2 3/9] vfio: add quirk device write method, P J P, 2020/06/24
- [PATCH v2 2/9] pci-host: add pcie-msi read method, P J P, 2020/06/24
- [PATCH v2 9/9] memory: assert MemoryRegionOps callbacks are defined, P J P, 2020/06/24
- [PATCH v2 7/9] tz-ppc: add dummy read/write methods, P J P, 2020/06/24