[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 29/30] gitlab: limit re-builds of the containers
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 29/30] gitlab: limit re-builds of the containers |
Date: |
Mon, 29 Jun 2020 11:03:50 +0100 |
User-agent: |
Mutt/1.14.3 (2020-06-14) |
On Fri, Jun 26, 2020 at 07:13:56PM +0100, Alex Bennée wrote:
> Most of the time we are just rebuilding the same things. We can skip
> this although currently there is no mechanism for picking up new
> distro releases.
>
> Rather than try to be too fine grained allow any change to trigger all
> the images being rebuilt.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> .gitlab-ci.d/containers.yml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.gitlab-ci.d/containers.yml b/.gitlab-ci.d/containers.yml
> index 20b2fb1de5d..f56aa44f711 100644
> --- a/.gitlab-ci.d/containers.yml
> +++ b/.gitlab-ci.d/containers.yml
> @@ -19,6 +19,10 @@
> - docker push "$TAG"
> after_script:
> - docker logout
> + only:
> + changes:
> + - .gitlab-ci.d/containers.yml
> + - tests/docker/*
How does this work for a person who forks the QEMU git repo and pushes
a change which doesn't touch the containers.yml file ? AFAICT, all
their jobs will fail due to not having previously built any container
images in their brand new fork.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH v3 19/30] gitlab: build all container images during CI, (continued)
[PATCH v3 24/30] gitlab: add acceptance testing to system builds, Alex Bennée, 2020/06/26
[PATCH v3 27/30] gitlab: add avocado asset caching, Alex Bennée, 2020/06/26