[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN.
From: |
Stefan Hajnoczi |
Subject: |
Re: [PATCH] util/coroutine: Cleanup start_switch_fiber_ for TSAN. |
Date: |
Mon, 29 Jun 2020 14:26:40 +0100 |
On Fri, Jun 26, 2020 at 01:00:01PM -0400, Robert Foley wrote:
> This is a cleanup patch to follow-up the patch which introduced TSAN.
> This patch makes separate start_switch_fiber_ functions for TSAN and ASAN.
>
> This does two things:
> 1. Unrelated ASAN and TSAN code is separate and each function only
> has arguments that are actually needed.
> 2. The co->tsan_caller_fiber and co->tsan_co_fiber fields are only
> access from within #ifdef CONFIG_TSAN.
>
> Signed-off-by: Robert Foley <robert.foley@linaro.org>
> ---
> util/coroutine-ucontext.c | 52 +++++++++++++++++++++++++--------------
> 1 file changed, 34 insertions(+), 18 deletions(-)
Thank you for revisiting this patch after it was applied!
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
signature.asc
Description: PGP signature