[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/9] nvram: add nrf51_soc flash read method
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v2 5/9] nvram: add nrf51_soc flash read method |
|
Date: |
Mon, 29 Jun 2020 17:32:16 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 29/06/20 13:55, P J P wrote:
> |
> | I prefer here just 'qemu_log_mask(LOG_UNIMP, "%s not implemented\n",
> | __func__);' as other patches does.
>
> Earlier patch v1 did that. It was suggested to return ldl_le_p(), as that's a
> valid return IIUC, instead of a zero(0), in case flash_read() is called.
>
> Thanks so much for the reviews. I'll send a revised series with due updates.
I think abort() is preferable (while LOG_UNIMP is wrong as it implies
there is something to do that QEMU is not doing).
Paolo
- Re: [PATCH v2 7/9] tz-ppc: add dummy read/write methods, (continued)
[PATCH v2 4/9] prep: add ppc-parity write method, P J P, 2020/06/24
[PATCH v2 5/9] nvram: add nrf51_soc flash read method, P J P, 2020/06/24
Re: [PATCH v2 5/9] nvram: add nrf51_soc flash read method, Paolo Bonzini, 2020/06/29
[PATCH v2 6/9] spapr_pci: add spapr msi read method, P J P, 2020/06/24
[PATCH v2 8/9] imx7-ccm: add digprog mmio write method, P J P, 2020/06/24
Re: [PATCH v2 0/9] memory: assert and define MemoryRegionOps callbacks, no-reply, 2020/06/24