[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/26] test-util-filemonitor: Plug unlikely memory leak
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH v3 10/26] test-util-filemonitor: Plug unlikely memory leak |
|
Date: |
Tue, 30 Jun 2020 10:20:17 +0100 |
|
User-agent: |
Mutt/1.14.3 (2020-06-14) |
On Tue, Jun 30, 2020 at 11:03:35AM +0200, Markus Armbruster wrote:
> test_file_monitor_events() leaks an Error object when
> qemu_file_monitor_add_watch() fails, which seems unlikely. Plug it.
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/test-util-filemonitor.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v3 00/26] Error handling fixes & cleanups, Markus Armbruster, 2020/06/30
- [PATCH v3 04/26] tests: Use &error_abort where appropriate, Markus Armbruster, 2020/06/30
- [PATCH v3 10/26] test-util-filemonitor: Plug unlikely memory leak, Markus Armbruster, 2020/06/30
- Re: [PATCH v3 10/26] test-util-filemonitor: Plug unlikely memory leak,
Daniel P . Berrangé <=
- [PATCH v3 05/26] tests: Use error_free_or_abort() where appropriate, Markus Armbruster, 2020/06/30
- [PATCH v3 08/26] qga: Plug unlikely memory leak in guest-set-memory-blocks, Markus Armbruster, 2020/06/30
- [PATCH v3 07/26] spapr: Plug minor memory leak in spapr_machine_init(), Markus Armbruster, 2020/06/30
- [PATCH v3 09/26] sd/milkymist-memcard: Plug minor memory leak in realize, Markus Armbruster, 2020/06/30
- [PATCH v3 12/26] aspeed: Clean up roundabout error propagation, Markus Armbruster, 2020/06/30
- [PATCH v3 13/26] qdev: Drop qbus_set_bus_hotplug_handler() parameter @errp, Markus Armbruster, 2020/06/30
- [PATCH v3 14/26] qdev: Drop qbus_set_hotplug_handler() parameter @errp, Markus Armbruster, 2020/06/30
- [PATCH v3 03/26] Clean up some calls to ignore Error objects the right way, Markus Armbruster, 2020/06/30