|
From: | Markus Armbruster |
Subject: | Re: [PATCH 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus() |
Date: | Tue, 30 Jun 2020 11:28:00 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Philippe Mathieu-Daudé <f4bug@amsat.org> writes: > Simplify aspeed_i2c_get_bus() by using a AspeedI2CState argument. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> The real motivation seems to be simplifying the callers: every single one of them casts the argument from AspeedI2CState * to DeviceState *. Pointing that out in the commit message wouldn't hurt. Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Prev in Thread] | Current Thread | [Next in Thread] |