Re: [PATCH] Revert "tests/migration: Reduce autoconverge initial bandwidth"

[Michael S. Tsirkin]

On Tue, Jun 30, 2020 at 02:59:12PM +0100, Dr. David Alan Gilbert wrote:
> * Michael S. Tsirkin (mst@redhat.com) wrote:
> > On Tue, Jun 23, 2020 at 10:57:02AM -0400, Michael S. Tsirkin wrote:
> > > This reverts commit 6d1da867e65f ("tests/migration: Reduce autoconverge 
> > > initial bandwidth")
> > > since that change makes unit tests much slower for all developers, while 
> > > it's not
> > > a robust way to fix migration tests. Migration tests need to find
> > > a more robust way to discover a reasonable bandwidth without slowing
> > > things down for everyone.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > 
> > What's the conclusion here? Should I merge this?
> 
> Yes please; I need to rethink that.
> 
> Dave
> 
> > 
> > > ---
> > >  tests/qtest/migration-test.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> > > index dc3490c9fa..21ea5ba1d2 100644
> > > --- a/tests/qtest/migration-test.c
> > > +++ b/tests/qtest/migration-test.c
> > > @@ -1211,7 +1211,7 @@ static void test_migrate_auto_converge(void)
> > >       * without throttling.
> > >       */
> > >      migrate_set_parameter_int(from, "downtime-limit", 1);
> > > -    migrate_set_parameter_int(from, "max-bandwidth", 1000000); /* ~1Mb/s 
> > > */
> > > +    migrate_set_parameter_int(from, "max-bandwidth", 100000000); /* 
> > > ~100Mb/s */
> > >  
> > >      /* To check remaining size after precopy */
> > >      migrate_set_capability(from, "pause-before-switchover", true);
> > > -- 
> > > MST
> > 
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK

ack pls?