[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/41] accel/kvm: Convert to ram_block_discard_disable()
From: |
Michael S. Tsirkin |
Subject: |
[PULL 07/41] accel/kvm: Convert to ram_block_discard_disable() |
Date: |
Fri, 3 Jul 2020 05:03:48 -0400 |
From: David Hildenbrand <david@redhat.com>
Discarding memory does not work as expected. At the time this is called,
we cannot have anyone active that relies on discards to work properly.
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20200626072248.78761-5-david@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
accel/kvm/kvm-all.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
index d54a8701d8..ab36fbfa0c 100644
--- a/accel/kvm/kvm-all.c
+++ b/accel/kvm/kvm-all.c
@@ -40,7 +40,6 @@
#include "trace.h"
#include "hw/irq.h"
#include "sysemu/sev.h"
-#include "sysemu/balloon.h"
#include "qapi/visitor.h"
#include "qapi/qapi-types-common.h"
#include "qapi/qapi-visit-common.h"
@@ -2229,7 +2228,8 @@ static int kvm_init(MachineState *ms)
s->sync_mmu = !!kvm_vm_check_extension(kvm_state, KVM_CAP_SYNC_MMU);
if (!s->sync_mmu) {
- qemu_balloon_inhibit(true);
+ ret = ram_block_discard_disable(true);
+ assert(!ret);
}
return 0;
--
MST
- [PULL 00/41] virtio,acpi: features, fixes, cleanups., Michael S. Tsirkin, 2020/07/03
- [PULL 01/41] tests: disassemble-aml.sh: generate AML in readable format, Michael S. Tsirkin, 2020/07/03
- [PULL 02/41] Revert "tests/migration: Reduce autoconverge initial bandwidth", Michael S. Tsirkin, 2020/07/03
- [PULL 03/41] virtio-balloon: always indicate S_DONE when migration fails, Michael S. Tsirkin, 2020/07/03
- [PULL 04/41] pc: Support coldplugging of virtio-pmem-pci devices on all buses, Michael S. Tsirkin, 2020/07/03
- [PULL 05/41] exec: Introduce ram_block_discard_(disable|require)(), Michael S. Tsirkin, 2020/07/03
- [PULL 06/41] vfio: Convert to ram_block_discard_disable(), Michael S. Tsirkin, 2020/07/03
- [PULL 07/41] accel/kvm: Convert to ram_block_discard_disable(),
Michael S. Tsirkin <=
- [PULL 08/41] s390x/pv: Convert to ram_block_discard_disable(), Michael S. Tsirkin, 2020/07/03
- [PULL 09/41] virtio-balloon: Rip out qemu_balloon_inhibit(), Michael S. Tsirkin, 2020/07/03
- [PULL 10/41] target/i386: sev: Use ram_block_discard_disable(), Michael S. Tsirkin, 2020/07/03
- [PULL 11/41] migration/rdma: Use ram_block_discard_disable(), Michael S. Tsirkin, 2020/07/03
- [PULL 13/41] virtio-mem: Paravirtualized memory hot(un)plug, Michael S. Tsirkin, 2020/07/03
- [PULL 14/41] virtio-pci: Proxy for virtio-mem, Michael S. Tsirkin, 2020/07/03