Re: [PATCH v4 08/21] microvm/acpi: add minimal acpi support

[Michael S. Tsirkin]

On Fri, Jul 03, 2020 at 09:25:10PM +0200, Gerd Hoffmann wrote:
> On Fri, Jul 03, 2020 at 09:09:43AM -0400, Michael S. Tsirkin wrote:
> > On Thu, Jul 02, 2020 at 10:48:46PM +0200, Gerd Hoffmann wrote:
> > > +    /* copy AML table into ACPI tables blob and patch header there */
> > > +    g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len);
> > > +    build_header(linker, table_data,
> > > +        (void *)(table_data->data + table_data->len - dsdt->buf->len),
> > > +        "DSDT", dsdt->buf->len, 5, NULL, NULL);
> > 
> > Why 5? Just curious ...
> 
> IIRC because the hw reduced hardware profile needs acpi 5+ ...
> 
> take care,
>   Gerd

Well ACPI spec 5 says revision value is 2.


Let's use standard practice in ACPI code, and add comments near each
value documenting earliest spec revision where this appeared, chapter
where they came from and some verbatim text that both explains and can
be searched for in later spec revisions.

In fact, same applies to a bunch of other code in this patchset
which just uses macros which does not help all that much
as they don't appear in spec as is. Can you pls go over it
and add such comments where appropriate?

-- 
MST