Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only

From:	Eric Blake
Subject:	Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only
Date:	Mon, 6 Jul 2020 09:00:31 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 7/3/20 10:12 AM, Thomas Huth wrote:

+++ b/util/qemu-openpty.c
@@ -35,7 +35,7 @@
  #include "qemu/osdep.h"
  #include "qemu-common.h"

-#if defined(__GLIBC__)

+#if defined CONFIG_PTY


Shouldn't there be some parentheses around CONFIG_PTY here?

No, they are optional, and omitting them is more consistent with theCONFIG_BSD just below.


>  #elif defined CONFIG_BSD
>  # include <termios.h>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v3 0/9] Build fixes for Haiku, Peter Maydell, 2020/07/03
- [PATCH v3 1/9] build: Enable BSD symbols for Haiku, Peter Maydell, 2020/07/03
- [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only, Peter Maydell, 2020/07/03
  - Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only, Thomas Huth, 2020/07/03
    - Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only, Eric Blake <=
    - Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only, Thomas Huth, 2020/07/06
- [PATCH v3 3/9] build: Check that mlockall() exists, Peter Maydell, 2020/07/03
  - Re: [PATCH v3 3/9] build: Check that mlockall() exists, Thomas Huth, 2020/07/03
- [PATCH v3 4/9] osdep.h: Always include <sys/signal.h> if it exists, Peter Maydell, 2020/07/03
  - Re: [PATCH v3 4/9] osdep.h: Always include <sys/signal.h> if it exists, Thomas Huth, 2020/07/03
    - Re: [PATCH v3 4/9] osdep.h: Always include <sys/signal.h> if it exists, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH v3 6/9] bswap.h: Include <endian.h> on Haiku for bswap operations, Peter Maydell, 2020/07/03
  - Re: [PATCH v3 6/9] bswap.h: Include <endian.h> on Haiku for bswap operations, Thomas Huth, 2020/07/03
  - Re: [PATCH v3 6/9] bswap.h: Include <endian.h> on Haiku for bswap operations, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH v3 5/9] osdep.h: For Haiku, define SIGIO as equivalent to SIGPOLL, Peter Maydell, 2020/07/03

Prev by Date: Re: [PATCH v9 34/34] iotests: Add tests for qcow2 images with extended L2 entries
Next by Date: Re: [PATCH v2 4/9] hw/arm/smmu: Simplify the IOTLB key format
Previous by thread: Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only
Next by thread: Re: [PATCH v3 2/9] util/qemu-openpty.c: Don't assume pty.h is glibc-only
Index(es):
- Date
- Thread