[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/7] audio: Spring cleaning
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH 0/7] audio: Spring cleaning |
|
Date: |
Mon, 6 Jul 2020 20:46:10 +0200 |
On Mon, Jul 06, 2020 at 08:09:47PM +0200, Philippe Mathieu-Daudé wrote:
> Hi Gerd,
>
> On 5/5/20 3:25 PM, Philippe Mathieu-Daudé wrote:
> > Cleaning old branches, salvaging what seems worthwhile...
> > This series is from the time I wanted cleaner buffer handling
> > to avoid abuses, started with chardev/ but got lost with reviews.
> > audio/ is smaller, so easier.
> >
> > - Convert various prototypes to use const buffers
> > - Expose 'audio/audio.h' via public include directory.
>
> You didn't commented on this series.
>
> We might use a LPVOID in dsound_get_buffer_in() as suggested
> by Volker but I don't like it much. What do you think otherwise?
Well, your reply to Volker was "This is unfortunate, because a single
backend invalidates the whole series.", so I dropped it from my
TODO/review/merge list ...
Tagging the buffers as const, then cast the const away (even if only
in dsound) isn't a good idea IMHO.
take care,
Gerd