[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Slow down with: 'Make "info qom-tree" show children sorted'
From: |
Thomas Huth |
Subject: |
Slow down with: 'Make "info qom-tree" show children sorted' |
Date: |
Tue, 7 Jul 2020 06:45:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 |
On 27/05/2020 10.47, Markus Armbruster wrote:
> "info qom-tree" prints children in unstable order. This is a pain
> when diffing output for different versions to find change. Print it
> sorted.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qom/qom-hmp-cmds.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
Hi Markus,
this patch causes a slow down of the qtests which becomes quite massive
when e.g. using the ppc64 and thourough testing. When I'm running
QTEST_QEMU_BINARY="ppc64-softmmu/qemu-system-ppc64" time \
./tests/qtest/device-introspect-test -m slow | tail -n 10
the test runs for ca. 6m40s here before the patch got applied, and for
mor than 20 minutes after the patch got applied!
This causes our gitlab CI to constantly fail since the patch got merged,
since the testing time now exceeds the 1h time limit:
https://gitlab.com/qemu-project/qemu/-/pipelines/156767175
Sure, we can work around that problem in the CI (Alex has already a
patch queued), but still, is there something you could do about this
massive slowdown?
Thanks,
Thomas
- Slow down with: 'Make "info qom-tree" show children sorted',
Thomas Huth <=
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Philippe Mathieu-Daudé, 2020/07/07
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Markus Armbruster, 2020/07/07
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Paolo Bonzini, 2020/07/07
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Markus Armbruster, 2020/07/07
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Daniel P . Berrangé, 2020/07/07
- Re: Slow down with: 'Make "info qom-tree" show children sorted', David Gibson, 2020/07/12
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Markus Armbruster, 2020/07/13
- Re: Slow down with: 'Make "info qom-tree" show children sorted', David Gibson, 2020/07/15
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Markus Armbruster, 2020/07/16
- Re: Slow down with: 'Make "info qom-tree" show children sorted', David Gibson, 2020/07/17