[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Slow down with: 'Make "info qom-tree" show children sorted'
From: |
Paolo Bonzini |
Subject: |
Re: Slow down with: 'Make "info qom-tree" show children sorted' |
Date: |
Tue, 7 Jul 2020 11:49:12 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 07/07/20 11:40, Daniel P. Berrangé wrote:
>
> The info qom-tree calls could be pushed outside the loop
>
> info qom-tree
> for each device type
> device_addr type,help
> info qom-tree
>
> Taking /x86_64/device/introspect/concrete/defaults/pc-q35-5.1 as a
> example, this change is the difference between 20 seconds running and
> 3 seconds running.
Or even, saving half the runtime:
info qom-tree
for each device type
device_addr type,help
info qom-tree
Paolo
> Reverting Markus' change actually didn't make much difference, only
> reducing the 20 seconds to 17 seconds.
>
> The downside is that if there is a stray object/crash, it would not
> immediately associate with the device type. I'm not sure that's a
> real problem though. Especially if we are running this as pre-merge
> CI we'll only need to look at the patch series to find the broken
> device. If this is quick enough that we can run it as standard,
> instead of only with -m slow, then its a net win I think.
- Re: Slow down with: 'Make "info qom-tree" show children sorted', (continued)
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Markus Armbruster, 2020/07/07
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Daniel P . Berrangé, 2020/07/07
- Re: Slow down with: 'Make "info qom-tree" show children sorted', David Gibson, 2020/07/12
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Markus Armbruster, 2020/07/13
- Re: Slow down with: 'Make "info qom-tree" show children sorted', David Gibson, 2020/07/15
- Re: Slow down with: 'Make "info qom-tree" show children sorted', Markus Armbruster, 2020/07/16
- Re: Slow down with: 'Make "info qom-tree" show children sorted', David Gibson, 2020/07/17
Re: Slow down with: 'Make "info qom-tree" show children sorted', Daniel P . Berrangé, 2020/07/07
Re: Slow down with: 'Make "info qom-tree" show children sorted', Daniel P . Berrangé, 2020/07/07