Re: hw/intc/xics.c:605: ics_realize: Assertion `ics->xics' failed

[Greg Kurz]

On Tue, 7 Jul 2020 16:11:55 +0200
Greg Kurz <groug@kaod.org> wrote:

> On Tue, 7 Jul 2020 13:01:54 +0200
> Thomas Huth <thuth@redhat.com> wrote:
> 
> > 
> >  Hi Greg,
> > 
> > I just ran  scripts/device-crash-test and it triggered the assert that
> > you've added in commit b015a9809427c8 ("xics: Link ICS_PROP_XICS
> > property to ICSState::xics pointer"):
> > 
> > $ qemu-system-ppc64 -S -M powernv9,accel=tcg -device pnv-psi-POWER8

Ah I hadn't realized you had a PSI device on the command line...

> > qemu-system-ppc64: hw/intc/xics.c:605: ics_realize: Assertion
> > `ics->xics' failed.
> > Aborted (core dumped)
> > 
> > That's ugly. Could you please have a look how this could be done in a
> > nicer way? (Maybe set errp and return in that case?)
> > 

PSI devices are really internal to the chip, they shouldn't be
instantiated from the command line. I'll send a patch to make
them not user creatable.

> >  Thanks,
> >   Thomas
> > 
> 
> Hi Thomas,
> 
> I'll look at that right away. Thanks for the report.
> 
> Cheers,
> 
> --
> Greg