Re: [PATCH 3/3] cpu-timers, icount: new modules

[Claudio Fontana]

On 7/8/20 5:23 PM, Paolo Bonzini wrote:
> On 08/07/20 17:17, Claudio Fontana wrote:
>> On 7/8/20 5:05 PM, Paolo Bonzini wrote:
>>> On 08/07/20 17:00, Claudio Fontana wrote:
>>>>> Bisectable, 100% failure rate, etc. :(  Can you split the patch in
>>>>> multiple parts, specifically separating any rename or introducing of
>>>>> includes from the final file move?
>>>> Hi Paolo,
>>>>
>>>> will take a look!
>>>>
>>>> Is this captured by some travis / cirrus-ci / anything I can easily see 
>>>> the result of?
>>>>
>>>>
>>>
>>> Nope, unfortunately we don't have an s390 CI.  But if you can get your
>>> hands on one, just "./configure --target-list=s390x-softmmu && make &&
>>> make check-block" will show it.
>>>
>>>>>
>>>>>   #if defined CONFIG_TCG || !defined NEED_CPU_H
>>>>>   extern bool icount_enabled(void);
>>>>>   #else
>>>>>   #define icount_enabled() 0
>>>>>   #endif
>>>>>
>>>>> (This way, more TCG-only code in cpus.c gets elided).  You can integrate
>>>>> this change in the next version.
>>>>>
>>>>> Paolo
>>>>>
>>>>
>>>> Weird, I tested with --disable-tcg explicitly (but may be some time ago 
>>>> now, as I constantly rebased).
>>>>
>>>> Will take a look at the introduction of this #defines in place of 
>>>> variables,
>>>> as this mechanisms will not work in the future for target-specific modules.
>>>
>>> This is only done for per-target files so it should not be a problem.
>>>
>>> Paolo
>>>
>>
>> K, I tried with latest master, disable-tcg build still works for me on x86, 
>> so it is something in queue I guess?
> 
> Peter reported the issue in the v1 pull request; there were two
> different breakages but the cpus.c one was yours.
> 
> Paolo
> 

I see, since I don't manage to reproduce the problem at the moment, I will wait 
for master to be updated, after which I expect the issue to become apparent.

As of now, I do

configure --disable-tcg
make -j120

which works for me, based on latest master.

Ciao,

C