RE: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to v1.3

[Dmitry Fomichev]

> -----Original Message-----
> From: Klaus Jensen <its@irrelevant.dk>
> Sent: Wednesday, July 8, 2020 5:24 PM
> To: Dmitry Fomichev <Dmitry.Fomichev@wdc.com>
> Cc: qemu-block@nongnu.org; qemu-devel@nongnu.org; fam@euphon.net;
> javier.gonz@samsung.com; kwolf@redhat.com; mreitz@redhat.com;
> mlevitsk@redhat.com; philmd@redhat.com; kbusch@kernel.org;
> k.jensen@samsung.com
> Subject: Re: [PATCH v3 01/18] hw/block/nvme: bump spec data structures to
> v1.3
> 
> On Jul  8 19:19, Dmitry Fomichev wrote:
> > Looks good with a small nit (see below),
> >
> > Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
> >
> > >
> > On Mon, 2020-07-06 at 08:12 +0200, Klaus Jensen wrote:
> > > +#define NVME_TEMP_TMPTH(temp) ((temp >>  0) & 0xffff)
> >
> > There is an extra space after temp >>
> >
> 
> Good catch! I won't repost for this ;) - but I'll fix it and add it in
> the qemu-nvme tree.

Yes, no need to repost :) Thanks for reviewing our ZNS series! I am working
on addressing your comments and I am also starting to review your
"AIO and address mapping refactoring" patchset.

Cheers,
Dmitry