qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/7] hw/rtc/m48t59: Reduce timer precision to milli-second


From: Richard Henderson
Subject: Re: [PATCH 5/7] hw/rtc/m48t59: Reduce timer precision to milli-second
Date: Wed, 8 Jul 2020 16:39:41 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0

On 6/16/20 12:51 AM, Philippe Mathieu-Daudé wrote:
> +    timer_mod(NVRAM->alrm_timer_ms,
> +              qemu_clock_get_ms(rtc_clock) + next_time_s *
> +                                             NANOSECONDS_PER_SECOND / 
> SCALE_MS);

I'm not keen on this last.

I would much prefer a MILLISECONDS_PER_SECOND define.  Should we in fact change
the units of the input...


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]