Re: [PATCH] tests: improve performance of device-introspect-test

[Laurent Vivier]

On 09/07/2020 13:59, Daniel P. Berrangé wrote:
> On Thu, Jul 09, 2020 at 01:44:45PM +0200, Laurent Vivier wrote:
>> On 09/07/2020 13:28, Daniel P. Berrangé wrote:
>>> Total execution time with "-m slow" and x86_64 QEMU, drops from 3
>>> minutes 15 seconds, down to 54 seconds.
>>>
>>> Individual tests drop from 17-20 seconds, down to 3-4 seconds.
>>>
>>> The cost of this change is that any QOM bugs resulting in the test
>>> failure will not be directly associated with the device that caused
>>> the failure. The test case is not frequently identifying such bugs
>>> though, and the cause is likely easily visible in the patch series
>>> that causes the failure. So overall the shorter running time is
>>> considered the more important factor.
>>
>> You don't report the test to test_device_intro_none() and
>> test_device_intro_abstract(): is it intended ?
> 
> Since neither of those tests will result in any device being created there
> didn't seem any point in chceking the qtree output.
> 
> IIUC, both of those tests should result in an error being reported from
> the device_add command, but I see nothing actually validates that is the
> case. 

I think the purpose of these tests is precisely to ensure nothing is
created. This is why they check the qtree and not the reported error.

Markus?

Thanks,
Laurent