[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/18] migration/vmstate: Introduce vmstate_no_state_to_migra
From: |
Peter Maydell |
Subject: |
Re: [PATCH 02/18] migration/vmstate: Introduce vmstate_no_state_to_migrate |
Date: |
Thu, 9 Jul 2020 20:00:34 +0100 |
On Fri, 3 Jul 2020 at 21:19, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> Introduce a special state to indicate when an object doesn't
> have anything in its state to migrate.
>
> Suggested-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/migration/vmstate.h | 1 +
> migration/vmstate.c | 7 +++++++
> 2 files changed, 8 insertions(+)
>
> diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
> index af7d80cd4e..0922bc8efa 100644
> --- a/include/migration/vmstate.h
> +++ b/include/migration/vmstate.h
> @@ -195,6 +195,7 @@ struct VMStateDescription {
> };
>
> extern const VMStateDescription vmstate_dummy; /* Exclusively for linux-user
> */
> +extern const VMStateDescription vmstate_no_state_to_migrate;
>
> extern const VMStateInfo vmstate_info_bool;
>
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index bafa890384..d640cafad3 100644
> --- a/migration/vmstate.c
> +++ b/migration/vmstate.c
> @@ -20,6 +20,13 @@
> #include "trace.h"
> #include "qjson.h"
>
> +const VMStateDescription vmstate_no_state_to_migrate = {
> + .name = "empty-state",
> + .fields = (VMStateField[]) {
> + VMSTATE_END_OF_LIST()
> + }
> +};
Does this definitely not put any data into the migration stream?
We don't want to change what's on the wire for machines that
use devices that start using this. (If it does by default, it
would be easy to make the migration code special case the
magic symbol to act like "no vmsd specified").
thanks
-- PMM
- [PATCH 00/18] hw: Mark the device with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 01/18] migration/vmstate: Document vmstate_dummy, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 02/18] migration/vmstate: Introduce vmstate_no_state_to_migrate, Philippe Mathieu-Daudé, 2020/07/03
- Re: [PATCH 02/18] migration/vmstate: Introduce vmstate_no_state_to_migrate,
Peter Maydell <=
- [PATCH 03/18] hw/core/qdev: Add vmstate_qdev_no_state_to_migrate, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 05/18] hw/arm/aspeed_soc: Mark the device with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 04/18] hw/arm/armv7m: Mark the device with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 06/18] hw/arm/bcm283x: Mark devices with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 07/18] hw/arm/msf2-soc: Mark the device with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 08/18] hw/core/split-irq: Mark the device with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 09/18] hw/cpu/a9mpcore: Mark the device with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03
- [PATCH 10/18] hw/cpu/cluster: Mark the device with no migratable fields, Philippe Mathieu-Daudé, 2020/07/03