Re: [PULL v2 00/52] Misc patches for QEMU 5.1 soft freeze

[Peter Maydell]

On Fri, 10 Jul 2020 at 13:52, Claudio Fontana <cfontana@suse.de> wrote:
> If you can access it,
>
> https://cirrus-ci.com/task/5537514263937024?command=main#L2039
>
> the thing is treated here as a warning, which is in the middle of a large 
> amount of other warnings.
>
> private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/ui/vnc-auth-sasl.c:648:29:
>  warning: 'sasl_errdetail' is deprecated: first deprecated in macOS 10.11 
> [-Wdeprecated-declarations]
>                             sasl_errdetail(vs->sasl.conn));
>
> /* ... lots of similar warnings */
>
> private/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/cirrus-ci-build/ui/cocoa.m:1478:9:
>  warning: implicit declaration of function 'cpu_throttle_set' is invalid in 
> C99 [-Wimplicit-function-declaration]
>         cpu_throttle_set(throttle_pct);
>         ^
>
>
> Apparently the cirrus-ci I am using is not treating this as an error, while 
> what you are using is..

Ah, I see. Yeah, configure by default doesn't enable -Werror for OSX.
My build tree has
 '--extra-cflags=-fdiagnostics-color=never -Werror
-Wno-error=deprecated-declarations'

(of which the last two are relevant here). We should probably
make configure use -Werror on OSX now with the same logic as Linux,
I've been using it that way for ages without issues.

thanks
-- PMM