Re: [PULL 00/32] AVR port

[Thomas Huth]

On 10/07/2020 13.41, Peter Maydell wrote:
> On Tue, 7 Jul 2020 at 19:19, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> Possible false-positives from checkpatch:
>>
>>   WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
>>
>> The following changes since commit 7623b5ba017f61de5d7c2bba12c6feb3d55091b1:
>>
>>   Merge remote-tracking branch 
>> 'remotes/vivier2/tags/linux-user-for-5.1-pull-=
>> request' into staging (2020-07-06 11:40:10 +0100)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.com/philmd/qemu.git tags/avr-port-20200707
>>
>> for you to fetch changes up to 0cdaf2f343491f60dbf7dd2a912cd88b5f9f899c:
>>
>>   target/avr/disas: Fix store instructions display order (2020-07-07 
>> 20:14:15=
>>  +0200)
>>
>> ----------------------------------------------------------------
>> 8bit AVR port from Michael Rolnik.
>>
>> Michael started to work on the AVR port few years ago [*] and kept
>> improving the code over various series.
> 
> Hi; I'm afraid this fails "make check" on big-endian hosts (s390x, ppc64):
> 
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_BINARY=avr-softmmu/qemu-system-avr QTEST_QEMU_IMG=qemu-img
> tests/qtest/boot-serial-test -m=quick -k --tap < /dev/null |
> ./scripts/tap-driver.pl --test-name="boot-serial-test"
> qemu-system-avr: execution left flash memory
> 
> ** (tests/qtest/boot-serial-test:24048): ERROR **: 11:00:46.466:
> Failed to find expected string. Please check
> '/tmp/qtest-boot-serial-sVGEXHI'
> ERROR - Bail out! FATAL-ERROR: Failed to find expected string. Please
> check '/tmp/qtest-boot-serial-sVGEXHI'

Endianess bug ... this should fix it:

diff --git a/target/avr/helper.c b/target/avr/helper.c
--- a/target/avr/helper.c
+++ b/target/avr/helper.c
@@ -337,6 +337,7 @@ void helper_fullwr(CPUAVRState *env, uint32_t data,
uint32_t addr)
         helper_outb(env, addr - NUMBER_OF_CPU_REGISTERS, data);
     } else {
         /* memory */
-        cpu_physical_memory_write(OFFSET_DATA + addr, &data, 1);
+        uint8_t data8 = data;
+        cpu_physical_memory_write(OFFSET_DATA + addr, &data8, 1);
     }
 }

 Thomas