Re: [PATCH 2/2] iotests: Set LC_ALL=C for sort

[Eric Blake]

On 7/10/20 11:32 AM, Max Reitz wrote:
> Otherwise the result is basically unpredictable.
>
> (Note that the precise environment variable to control sorting order is
> LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the
> sorting order to be messed up if LC_ALL is set in the environment.)

Yep, that logic is correct.

> Reported-by: John Snow <jsnow@redhat.com>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>   tests/qemu-iotests/common.filter | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
> index 345c3ca03e..4fd5c29b2a 100644
> --- a/tests/qemu-iotests/common.filter
> +++ b/tests/qemu-iotests/common.filter
> @@ -177,7 +177,7 @@ _do_filter_img_create()
>               -e 's/^\(data_file\)/3-\1/' \
>               -e 's/^\(encryption\)/4-\1/' \
>               -e 's/^\(preallocation\)/8-\1/' \
> -        | sort \
> +        | LC_ALL=C sort \
>           | $SED -e 's/^[0-9]-//' \
>           | tr '\n\0' ' \n' \
>           | $SED -e 's/^ *$//' -e 's/ *$//'

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org