[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-5.1] tcg: Save/restore vecop_list around minmax fallback
From: |
Richard Henderson |
Subject: |
[PATCH for-5.1] tcg: Save/restore vecop_list around minmax fallback |
Date: |
Fri, 10 Jul 2020 16:37:43 -0700 |
Forgetting this asserts when tcg_gen_cmp_vec is called from
within tcg_gen_cmpsel_vec.
Fixes: 72b4c792c7a
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
I found this while testing SVE2 (and the patch is included in the
large SVE2 patch set), but it seems like it should be reproducible
with master. What's needed is a guest vector minmax operation of
a size that is not supported by the host. In the case of x86_64
host, that would be a 64-bit minmax.
r~
---
tcg/tcg-op-vec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tcg/tcg-op-vec.c b/tcg/tcg-op-vec.c
index f784517d84..ed6fb55fe1 100644
--- a/tcg/tcg-op-vec.c
+++ b/tcg/tcg-op-vec.c
@@ -657,7 +657,9 @@ static void do_minmax(unsigned vece, TCGv_vec r, TCGv_vec a,
TCGv_vec b, TCGOpcode opc, TCGCond cond)
{
if (!do_op3(vece, r, a, b, opc)) {
+ const TCGOpcode *hold_list = tcg_swap_vecop_list(NULL);
tcg_gen_cmpsel_vec(cond, vece, r, a, b, a, b);
+ tcg_swap_vecop_list(hold_list);
}
}
--
2.25.1
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH for-5.1] tcg: Save/restore vecop_list around minmax fallback,
Richard Henderson <=