[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 50/50] iotests: Set LC_ALL=C for sort
From: |
Alex Bennée |
Subject: |
[PULL v2 50/50] iotests: Set LC_ALL=C for sort |
Date: |
Sat, 11 Jul 2020 18:07:32 +0100 |
From: Max Reitz <mreitz@redhat.com>
Otherwise the result is basically unpredictable.
(Note that the precise environment variable to control sorting order is
LC_COLLATE, but LC_ALL overrides LC_COLLATE, and we do not want the
sorting order to be messed up if LC_ALL is set in the environment.)
Reported-by: John Snow <jsnow@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20200710163253.381630-3-mreitz@redhat.com>
diff --git a/tests/qemu-iotests/common.filter b/tests/qemu-iotests/common.filter
index d967adc59a..c9f978abce 100644
--- a/tests/qemu-iotests/common.filter
+++ b/tests/qemu-iotests/common.filter
@@ -186,7 +186,7 @@ _filter_img_create()
-e 's/^\(data_file\)/3-\1/' \
-e 's/^\(encryption\)/4-\1/' \
-e 's/^\(preallocation\)/8-\1/' \
- | sort \
+ | LC_ALL=C sort \
| $SED -e 's/^[0-9]-//' \
| tr '\n\0' ' \n' \
| $SED -e 's/^ *$//' -e 's/ *$//'
--
2.20.1
- [PULL v2 00/50] testing updates (vm, gitlab, misc build fixes), Alex Bennée, 2020/07/11
- [PULL v2 04/50] tests/vm: Add configuration to basevm.py, Alex Bennée, 2020/07/11
- [PULL v2 42/50] docs/devel: convert and update MTTCG design document, Alex Bennée, 2020/07/11
- [PULL v2 43/50] docs/devel: add some notes on tcg-icount for developers, Alex Bennée, 2020/07/11
- [PULL v2 44/50] docs: Add to gdbstub documentation the PhyMemMode, Alex Bennée, 2020/07/11
- [PULL v2 45/50] tests/docker: fall back more gracefully when pull fails, Alex Bennée, 2020/07/11
- [PULL v2 46/50] tests/docker: update toolchain set in debian-xtensa-cross, Alex Bennée, 2020/07/11
- [PULL v2 47/50] .cirrus.yml: add bash to the brew packages, Alex Bennée, 2020/07/11
- [PULL v2 48/50] tests: fix "make check-qtest" for modular builds, Alex Bennée, 2020/07/11
- [PULL v2 49/50] Revert "vga: build virtio-gpu as module", Alex Bennée, 2020/07/11
- [PULL v2 50/50] iotests: Set LC_ALL=C for sort,
Alex Bennée <=
- Re: [PULL v2 00/50] testing updates (vm, gitlab, misc build fixes), Peter Maydell, 2020/07/13