qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/12] virtfs-proxy-helper: Remove the superfluous break


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 05/12] virtfs-proxy-helper: Remove the superfluous break
Date: Mon, 13 Jul 2020 11:08:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 7/13/20 11:04 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
> 
> Remove the superfluous break, as there is a "return" before it.
> 
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> 

Hmm I never reviewed this patch, only the openrisc one:
https://lists.gnu.org/archive/html/qemu-devel/2020-07/msg04078.html

Something is wrong in your workflow, you are posting each patch as
a new thread. You might be missing the --cc-cover option, see:
https://wiki.qemu.org/Contribute/SubmitAPatch#Use_git_format-patch

> ---
>  fsdev/virtfs-proxy-helper.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fsdev/virtfs-proxy-helper.c b/fsdev/virtfs-proxy-helper.c
> index de061a8..e68acc1 100644
> --- a/fsdev/virtfs-proxy-helper.c
> +++ b/fsdev/virtfs-proxy-helper.c
> @@ -825,7 +825,6 @@ static int process_reply(int sock, int type,
>          break;
>      default:
>          return -1;
> -        break;
>      }
>      return 0;
>  }
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]