[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/12] target/openrisc: Remove superfluous breaks
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 10/12] target/openrisc: Remove superfluous breaks |
Date: |
Mon, 13 Jul 2020 11:09:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/13/20 11:05 AM, Yi Wang wrote:
> From: Liao Pingfang <liao.pingfang@zte.com.cn>
>
> Remove superfluous breaks, as there is a "return" before them.
>
> Signed-off-by: Liao Pingfang <liao.pingfang@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
FYI the subject should say this is "PATCH v2", see:
https://wiki.qemu.org/Contribute/SubmitAPatch#When_resending_patches_add_a_version_tag
> ---
> target/openrisc/sys_helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target/openrisc/sys_helper.c b/target/openrisc/sys_helper.c
> index d9fe6c5..d9691d0 100644
> --- a/target/openrisc/sys_helper.c
> +++ b/target/openrisc/sys_helper.c
> @@ -289,10 +289,8 @@ target_ulong HELPER(mfspr)(CPUOpenRISCState *env,
> target_ulong rd,
>
> case TO_SPR(5, 1): /* MACLO */
> return (uint32_t)env->mac;
> - break;
> case TO_SPR(5, 2): /* MACHI */
> return env->mac >> 32;
> - break;
>
> case TO_SPR(8, 0): /* PMR */
> return env->pmr;
>