[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/aspeed: Do not create and attach empty SD cards by de
From: |
Peter Maydell |
Subject: |
Re: [PATCH] hw/arm/aspeed: Do not create and attach empty SD cards by default |
Date: |
Mon, 13 Jul 2020 13:24:24 +0100 |
On Mon, 13 Jul 2020 at 13:20, Cédric Le Goater <clg@kaod.org> wrote:
>
> On 7/5/20 7:34 PM, Philippe Mathieu-Daudé wrote:
> > Since added in commit 2bea128c3d, each SDHCI is wired with a SD
> > card, using empty card when no block drive provided. This is not
> > the desired behavior. The SDHCI exposes a SD bus to plug cards
> > on, if no card available, it is fine to have an unplugged bus.
> >
> > Avoid creating unnecessary SD card device when no block drive
> > provided.
> >
> > Fixes: 2bea128c3d ("hw/sd/aspeed_sdhci: New device")
> > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
Applied to target-arm.next for 5.1, thanks.
-- PMM