[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 06/12] python/machine.py: Add a configurable timeout to sh
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown() |
Date: |
Mon, 13 Jul 2020 22:50:24 -0400 |
On Fri, Jul 10, 2020 at 01:06:43AM -0400, John Snow wrote:
> Three seconds is hardcoded. Use it as a default parameter instead, and use
> that
> value for both waits that may occur in the function.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/machine.py | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Reviewed-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH v5 03/12] python/machine.py: Add _early_cleanup hook, (continued)
- [PATCH v5 05/12] python/machine.py: Prohibit multiple shutdown() calls, John Snow, 2020/07/10
- [PATCH v5 04/12] python/machine.py: Perform early cleanup for wait() calls, too, John Snow, 2020/07/10
- [PATCH v5 06/12] python/machine.py: Add a configurable timeout to shutdown(), John Snow, 2020/07/10
- [PATCH v5 07/12] python/machine.py: Make wait() call shutdown(), John Snow, 2020/07/10
- [PATCH v5 08/12] tests/acceptance: wait() instead of shutdown() where appropriate, John Snow, 2020/07/10
- [PATCH v5 09/12] tests/acceptance: Don't test reboot on cubieboard, John Snow, 2020/07/10