Re: [PATCH-for-5.1] net/colo: Remove unused trace event

[Daniel P . Berrangé]

On Wed, Jul 15, 2020 at 04:31:30PM +0200, Philippe Mathieu-Daudé wrote:
> Unused trace event cause build failure when using the dtrace backend:
> 
>   "probe colo_compare_miscompare doesn't exist"
> 
> Fixes: f4b618360e ("colo-compare: add TCP, UDP, ICMP packet comparison")
> Reported-by: Roman Bolshakov <r.bolshakov@yadro.com>

Note Roman indicated on IRC that this is seen with dtrace on macOS and
there were other problems too.

Unless someone knows that QEMU's dtrace support worked on macOS in the
past, I think we don't need  and simply consider dtrace unsupported on
macOS right now until someone can get it into more robust shape on
macOS.

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Cc: zhangchen.fnst@cn.fujitsu.com
> ---
>  net/trace-events | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/trace-events b/net/trace-events
> index fa49c71533..c3f623d40c 100644
> --- a/net/trace-events
> +++ b/net/trace-events
> @@ -17,7 +17,6 @@ colo_compare_udp_miscompare(const char *sta, int size) ": 
> %s = %d"
>  colo_compare_icmp_miscompare(const char *sta, int size) ": %s = %d"
>  colo_compare_ip_info(int psize, const char *sta, const char *stb, int ssize, 
> const char *stc, const char *std) "ppkt size = %d, ip_src = %s, ip_dst = %s, 
> spkt size = %d, ip_src = %s, ip_dst = %s"
>  colo_old_packet_check_found(int64_t old_time) "%" PRId64
> -colo_compare_miscompare(void) ""
>  colo_compare_tcp_info(const char *pkt, uint32_t seq, uint32_t ack, int 
> hdlen, int pdlen, int offset, int flags) "%s: seq/ack= %u/%u hdlen= %d pdlen= 
> %d offset= %d flags=%d"
>  
>  # filter-rewriter.c
> -- 
> 2.21.3
> 
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|