Re: [PATCH] virtiofsd: Remove "norace" from cmdline help

[Sergio Lopez]

On Fri, Jul 17, 2020 at 11:14:14AM +0200, Stefano Garzarella wrote:
> On Thu, Jul 16, 2020 at 12:14:42PM +0200, Sergio Lopez wrote:
> > Commit 93bb3d8d4cda ("virtiofsd: remove symlink fallbacks") removed
> > the implementation of the "norace" option, so remove it from the
> > cmdline help too.
> > 
> > Signed-off-by: Sergio Lopez <slp@redhat.com>
> > ---
> >  tools/virtiofsd/helper.c | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/tools/virtiofsd/helper.c b/tools/virtiofsd/helper.c
> > index 3105b6c23a..7bc5d7dc5a 100644
> > --- a/tools/virtiofsd/helper.c
> > +++ b/tools/virtiofsd/helper.c
> > @@ -159,8 +159,6 @@ void fuse_cmdline_help(void)
> >             "    -o max_idle_threads        the maximum number of idle 
> > worker "
> >             "threads\n"
> >             "                               allowed (default: 10)\n"
> > -           "    -o norace                  disable racy fallback\n"
> > -           "                               default: false\n"
> >             "    -o posix_lock|no_posix_lock\n"
> >             "                               enable/disable remote posix 
> > lock\n"
> >             "                               default: posix_lock\n"
> > -- 
> > 2.26.2
> > 
> > 
> 
> I noticed that 'norace' is also described in docs/tools/virtiofsd.rst,
> so I think we need to remove it there too:
> 
>     diff --git a/docs/tools/virtiofsd.rst b/docs/tools/virtiofsd.rst
>     index 824e713491..58666a4495 100644
>     --- a/docs/tools/virtiofsd.rst
>     +++ b/docs/tools/virtiofsd.rst
>     @@ -63,9 +63,6 @@ Options
>          Print only log messages matching LEVEL or more severe.  LEVEL is one 
> of
>          ``err``, ``warn``, ``info``, or ``debug``.  The default is ``info``.
> 
>     -  * norace -
>     -    Disable racy fallback.  The default is false.
>     -
>        * posix_lock|no_posix_lock -
>          Enable/disable remote POSIX locks.  The default is ``posix_lock``.

Good catch, thanks. I'll send a v2.

Sergio.

> With that fixed:
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> 
> Thanks,
> Stefano
>

signature.asc
Description: PGP signature