[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/12] file-posix: Fix leaked fd in raw_open_common() error path
From: |
Kevin Wolf |
Subject: |
[PULL 12/12] file-posix: Fix leaked fd in raw_open_common() error path |
Date: |
Fri, 17 Jul 2020 14:55:10 +0200 |
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20200717105426.51134-4-kwolf@redhat.com>
Reviewed-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/file-posix.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/block/file-posix.c b/block/file-posix.c
index 996e45ab95..8cc39a1ef6 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -773,6 +773,9 @@ static int raw_open_common(BlockDriverState *bs, QDict
*options,
}
ret = 0;
fail:
+ if (ret < 0 && s->fd != -1) {
+ qemu_close(s->fd);
+ }
if (filename && (bdrv_flags & BDRV_O_TEMPORARY)) {
unlink(filename);
}
--
2.25.4
- [PULL 03/12] qemu-img resize: Require --shrink for shrinking all image formats, (continued)
- [PULL 03/12] qemu-img resize: Require --shrink for shrinking all image formats, Kevin Wolf, 2020/07/17
- [PULL 02/12] Remove VXHS block device, Kevin Wolf, 2020/07/17
- [PULL 05/12] iotests/030: Reduce job speed to make race less likely, Kevin Wolf, 2020/07/17
- [PULL 06/12] nbd: make nbd_export_close_all() synchronous, Kevin Wolf, 2020/07/17
- [PULL 08/12] block: Require aligned image size to avoid assertion failure, Kevin Wolf, 2020/07/17
- [PULL 04/12] crypto: use a stronger private key for tests, Kevin Wolf, 2020/07/17
- [PULL 09/12] file-posix: Allow byte-aligned O_DIRECT with NFS, Kevin Wolf, 2020/07/17
- [PULL 07/12] iotests: test shutdown when bitmap is exported through NBD, Kevin Wolf, 2020/07/17
- [PULL 10/12] file-posix: Move check_hdev_writable() up, Kevin Wolf, 2020/07/17
- [PULL 11/12] file-posix: Fix check_hdev_writable() with auto-read-only, Kevin Wolf, 2020/07/17
- [PULL 12/12] file-posix: Fix leaked fd in raw_open_common() error path,
Kevin Wolf <=
- Re: [PULL 00/12] Block layer patches for 5.1.0-rc1, Peter Maydell, 2020/07/18