RE: [PATCH v2 2/3] usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c

[Sai Pavan Boddu]

Hi Thomas,

> -----Original Message-----
> From: Thomas Huth <thuth@redhat.com>
> Sent: Monday, July 20, 2020 1:37 PM
> To: Sai Pavan Boddu <saipava@xilinx.com>; Philippe Mathieu-Daudé
> <philmd@redhat.com>; Markus Armbruster <armbru@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>; Peter Maydell
> <peter.maydell@linaro.org>; Eduardo Habkost <ehabkost@redhat.com>;
> qemu-devel@nongnu.org; Alistair Francis <alistair.francis@wdc.com>;
> 'Marc-André Lureau' <marcandre.lureau@redhat.com>; Ying Fang
> <fangying1@huawei.com>; Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH v2 2/3] usb/hcd-xhci: Move qemu-xhci device to hcd-
> xhci-pci.c
> 
> On 20/07/2020 10.00, Sai Pavan Boddu wrote:
> > HI Philippe,
> >
> >> -----Original Message-----
> >> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> >> Sent: Thursday, June 25, 2020 1:48 PM
> >> To: Markus Armbruster <armbru@redhat.com>; Sai Pavan Boddu
> >> <saipava@xilinx.com>; Thomas Huth <thuth@redhat.com>
> >> Cc: Gerd Hoffmann <kraxel@redhat.com>; Peter Maydell
> >> <peter.maydell@linaro.org>; Eduardo Habkost <ehabkost@redhat.com>;
> >> qemu-devel@nongnu.org; Alistair Francis <alistair.francis@wdc.com>;
> >> 'Marc-André Lureau' <marcandre.lureau@redhat.com>; Ying Fang
> >> <fangying1@huawei.com>; Paolo Bonzini <pbonzini@redhat.com>
> >> Subject: Re: [PATCH v2 2/3] usb/hcd-xhci: Move qemu-xhci device to
> >> hcd- xhci-pci.c
> >>
> >> On 6/25/20 10:06 AM, Markus Armbruster wrote:
> >>> Sai Pavan Boddu <sai.pavan.boddu@xilinx.com> writes:
> >>>
> >>>> Move pci specific devices to new file. This set the environment to
> >>>> move all pci specific hooks in hcd-xhci.c to hcd-xhci-pci.c.
> >>>>
> >>>> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> >>>> ---
> >>>>  hw/usb/hcd-xhci-pci.c | 64
> >> +++++++++++++++++++++++++++++++++++++++++++++++++++
> >>>>  hw/usb/hcd-xhci.c     | 32 ++------------------------
> >>>>  hw/usb/hcd-xhci.h     |  2 ++
> >>>>  3 files changed, 68 insertions(+), 30 deletions(-)  create mode
> >>>> 100644 hw/usb/hcd-xhci-pci.c
> >>>>
> >>>> diff --git a/hw/usb/hcd-xhci-pci.c b/hw/usb/hcd-xhci-pci.c new file
> >>>> mode 100644 index 0000000..26af683
> >>>> --- /dev/null
> >>>> +++ b/hw/usb/hcd-xhci-pci.c
> >>>> @@ -0,0 +1,64 @@
> >>>> +/*
> >>>> + * USB xHCI controller with PCI system bus emulation
> >>>
> >>> Scratch "system".
> >>>
> >>>> + *
> >>>> + * Copyright (c) 2011 Securiforest
> >>>> + * Date: 2011-05-11 ;  Author: Hector Martin
> >>>> + <hector@marcansoft.com>
> >>>
> >>> Let's use the opportunity to drop the "Date: " part, because we
> >>> don't have it anywhere else.
> >>
> >> Good opportunity to suggest the SPDX tags again :P
> >>
> >> /*
> >>  * SPDX-FileCopyrightText: 2011 Securiforest
> >>  * SPDX-FileContributor: Hector Martin <hector@marcansoft.com>
> >>  * SPDX-FileCopyrightText: 2020 Xilinx Inc.
> >>  * SPDX-FileContributor: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> >>  * SPDX-License-Identifier: GPL-2.0-or-later  */
> > [Sai Pavan Boddu] I would include this in V4, Forgot them in V3.
> >
> > Thanks,
> > Sai Pavan
> >>
> >> https://spdx.org/rdf/ontology/spdx-2-0-
> >> rc/dataproperties/fileContributor___-1635717172.html
> >>
> >>>
> >>>> + * Based on usb-ohci.c, emulates Renesas NEC USB 3.0
> >>>> + * Date: 2020-03-01; Author: Sai Pavan Boddu
> >>>> + <sai.pavan.boddu@xilinx.com>
> >>>
> >>> And no new "Date: " parts, please.
> >>>
> >>>> + * Moved the pci specific content for hcd-xhci.c to hcd-xhci-pci.c
> >>>> + *
> >>>> + * This library is free software; you can redistribute it and/or
> >>>> + * modify it under the terms of the GNU Lesser General Public
> >>>> + * License as published by the Free Software Foundation; either
> >>>> + * version 2 of the License, or (at your option) any later version.
> 
> And while you're at it: There was never a "version 2" of the Lesser GPL.
> In version 2.0, it was still called "Library" GPL. So it is quite likely that 
> version
> 2.1 is meant here instead.
[Sai Pavan Boddu] I have less knowledge here. But indeed I don’t find LGPL 2.0 
https://www.gnu.org/licenses/licenses.html#LicenseURLs

BTW, I still see our repository use combination of GPL and LGPL. Is there any 
general rule to follow at high level.

Regards,
Sai Pavan
> 
>  Thomas