Re: [PATCH v2 08/12] linux-user: don't use MAP_FIXED in pgd_find_hole_fallback

[Richard Henderson]

On 7/21/20 11:28 PM, Alex Bennée wrote:
> Plain MAP_FIXED has the undesirable behaviour of splatting exiting
> maps so we don't actually achieve what we want when looking for gaps.
> We should be using MAP_FIXED_NOREPLACE. As this isn't always available
> we need to potentially check the returned address to see if the kernel
> gave us what we asked for.
> 
> Fixes: ad592e3
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  include/qemu/osdep.h |  3 +++
>  linux-user/elfload.c | 10 ++++++----
>  2 files changed, 9 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~