[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-5.1] sd/milkymist-memcard: Fix format string
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH for-5.1] sd/milkymist-memcard: Fix format string |
|
Date: |
Thu, 23 Jul 2020 10:50:42 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 7/22/20 10:40 PM, Stefan Weil wrote:
Fixes: b98e8d1230 ("sd/milkymist-memcard: Plug minor memory leak in
realize")
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/sd/milkymist-memcard.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/sd/milkymist-memcard.c b/hw/sd/milkymist-memcard.c
> index afdb8aa0c0..11f61294fc 100644
> --- a/hw/sd/milkymist-memcard.c
> +++ b/hw/sd/milkymist-memcard.c
> @@ -281,7 +281,7 @@ static void milkymist_memcard_realize(DeviceState *dev,
> Error **errp)
> carddev = qdev_new(TYPE_SD_CARD);
> qdev_prop_set_drive(carddev, "drive", blk);
> if (!qdev_realize_and_unref(carddev, BUS(&s->sdbus), &err)) {
> - error_propagate_prepend(errp, err, "failed to init SD card: %s");
> + error_propagate_prepend(errp, err, "failed to init SD card");
Oops... b98e8d1230 was to fix 3d0369ba49 ("hw/sd/milkymist-memcard:
expose a SDBus and connect the SDCard to it").
> return;
> }
> s->enabled = blk && blk_is_inserted(blk);
>