[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH] hw/input/virtio-input-hid.c: Don't undef CONFIG_CURSES |
|
Date: |
Fri, 24 Jul 2020 08:53:53 -0400 |
On Thu, Jul 23, 2020 at 08:24:57PM +0100, Peter Maydell wrote:
> virtio-input-hid.c undefines CONFIG_CURSES before including
> ui/console.h. However since commits e2f82e924d057935 and b0766612d16da18
> that header does not have behaviour dependent on CONFIG_CURSES.
> Remove the now-unneeded undef.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Gerd pls feel free to pick this up.
> ---
> NB: tested with 'make check' only.
>
> hw/input/virtio-input-hid.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/input/virtio-input-hid.c b/hw/input/virtio-input-hid.c
> index 09cf2609854..a7a244a95db 100644
> --- a/hw/input/virtio-input-hid.c
> +++ b/hw/input/virtio-input-hid.c
> @@ -12,7 +12,6 @@
> #include "hw/qdev-properties.h"
> #include "hw/virtio/virtio-input.h"
>
> -#undef CONFIG_CURSES
> #include "ui/console.h"
>
> #include "standard-headers/linux/input.h"
> --
> 2.20.1